Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CodeQL #202

Merged
merged 2 commits into from
Oct 16, 2023
Merged

Add CodeQL #202

merged 2 commits into from
Oct 16, 2023

Conversation

marcello33
Copy link
Contributor

Description

Add CodeQL as a CI workflow.

Changes

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Changes only for a subset of nodes

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply

Testing

  • I have added unit tests
  • I have added tests to CI
  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on mumbai
  • I have created new e2e tests into express-cli

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@marcello33 marcello33 force-pushed the mardizzone/POS-1466 branch 2 times, most recently from 11ac1a3 to cbfe8b8 Compare October 12, 2023 15:35
@marcello33 marcello33 requested a review from a team October 16, 2023 06:01
@marcello33 marcello33 merged commit 4761b3c into master Oct 16, 2023
8 of 11 checks passed
@marcello33 marcello33 deleted the mardizzone/POS-1466 branch November 16, 2023 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pratikspatil024 pratikspatil024 pratikspatil024 approved these changes

@0xsharma 0xsharma 0xsharma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marcello33 @0xsharma @pratikspatil024